two little bugs fixed in PluginManager

Third party modules, patches, bugfixes
Post Reply
User avatar
lasernic
Newbie
Posts: 5
Joined: Tue Oct 07, 2014 11:15 am
Version: forma.lms 1.2

two little bugs fixed in PluginManager

Post by lasernic » Wed Mar 11, 2015 4:09 pm

Hi everyone,

here is a little bug fix inside the model of the PluginManager.
There was a little inconsistency regarding the information collected from the learning_plugins table: the field "category" fetched in the SQL query string was ignored during the gather process inside getPluginsInfo, causing the returned array to be inconsistent (the active slot was filled with the description field, for example).
Moreover I also expose the value of the category field in the view of the page (it could be useful when you will have a lot - hope so! - of plugins available).

Another thing I notice is that there is a strange behavoiur regarding the field "priority" which you can set to 0 or 1 from the configurarion panel, but, as a matter of fact, the value of this field shouldn't be user definable...
Maybe here the Forma dev team could shed a light on this issue.

Please find my patch in the zip file in attachment. Just unpack the zip and substitute the original file

- [root_forma]/
---->appCore/
------>models
-------->PluginAdm.php (You can easily find the changes inside the code looking for my name inside the code)

There is another little bug I notice in 1.3 forma release: the file

[root_forma]/plugins/ConferenceTeleSkill/ConferenceTeleskillPlugin.php

must be renamed as

[root_forma]/plugins/ConferenceTeleSkill/ConferenceTeleSkillPlugin.php

otherwise you can happen to see a 500 internal server error (Fatal error caused by the fail in opening that file).
Attachments
PluginAdm_patched.zip
(3.02 KiB) Downloaded 20 times
Last edited by lasernic on Thu Mar 12, 2015 9:48 am, edited 1 time in total.
Saluti.

Nicola Laserra
--------------------------------
PHP Developer
Elma Informatica - http://www.elmainformatica.it
Via Vitruvio 38, Milano

User avatar
canelli
FormaLms Guru
Posts: 488
Joined: Thu Nov 08, 2012 12:21 pm
Version: forma.lms 2.0
Contact:

Re: two little bugs fixed in PluginManager

Post by canelli » Wed Mar 11, 2015 9:46 pm

Thank for your patch and bug fix
I will review the fix and set it to be included in one of the next releases . I hope to include your fix in the 1.4 release that is now in a beta stage.

I will collect some technical data and answer you
Cercate nel forum le riposte prima di chiedere. Check the forum before posting
---------------
Claudio Anelli
Joint Technologies - Sistemi avanzati per l'information technology

http://www.joint-tech.com
---------------

lingjingjing100
Newbie
Posts: 9
Joined: Thu Mar 19, 2015 9:30 am
Version: forma.lms 1.3

Re: two little bugs fixed in PluginManager

Post by lingjingjing100 » Fri Mar 20, 2015 6:37 am

3x,you update package,it help me,very well.and formalms is best for my work. thank u very much.
i 'm happy for new version.

User avatar
canelli
FormaLms Guru
Posts: 488
Joined: Thu Nov 08, 2012 12:21 pm
Version: forma.lms 2.0
Contact:

Re: two little bugs fixed in PluginManager

Post by canelli » Fri Mar 20, 2015 1:50 pm

the proposed fix wil lbe included in forma.lms 1.4 , coming soon
stay tuned
Cercate nel forum le riposte prima di chiedere. Check the forum before posting
---------------
Claudio Anelli
Joint Technologies - Sistemi avanzati per l'information technology

http://www.joint-tech.com
---------------

oscarjf
Newbie
Posts: 1
Joined: Sun Jan 03, 2016 2:41 am
Version: forma.lms 1.4.1

Re: two little bugs fixed in PluginManager

Post by oscarjf » Sun Jan 03, 2016 6:58 am

Thank.

Post Reply